Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a better looking comments #160

Closed
3 tasks
yammesicka opened this issue Sep 20, 2020 · 4 comments · Fixed by #366
Closed
3 tasks

Create a better looking comments #160

yammesicka opened this issue Sep 20, 2020 · 4 comments · Fixed by #366
Assignees
@yammesicka @ron-huberfeld
Labels
Enhancement New feature or request Frontend Hacktoberfest Important
Milestone
Better comments o...

Comments

@yammesicka
Copy link
Member

  • Create a slidedown, accordion-like comments section instead the current ugly popover.
  • Drop Bootstrap's popover.
  • Drop jQuery.
@ron-huberfeld
Copy link
Contributor

Hi @yammesicka, please assign to me

@ron-huberfeld
Copy link
Contributor

@yammesicka, I'm going to follow this article. Any objections?

@yammesicka
Copy link
Member Author

yammesicka commented Oct 15, 2021 •
edited
Loading

@ron-huberfeld That's look great!

Be sure to keep it simple, though: we currently don't need hierarchies of comments, mentions, votes or any other mechanism which is not just multiple comments per line.
If I had to implement this, I would probably look at existing comments mechanism on code-review systems and try to do something similar :)

@yammesicka yammesicka self-assigned this Feb 28, 2024
@yammesicka
Copy link
Member Author

yammesicka commented Feb 28, 2024 •
edited
Loading

WIP, see #366

image

@yammesicka yammesicka linked a pull request Mar 1, 2024 that will close this issue
feat: Better comments section #366
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yammesicka yammesicka

@ron-huberfeld ron-huberfeld

Labels
Enhancement New feature or request Frontend Hacktoberfest Important
Projects
None yet
Milestone
Better comments on exercises
Development

Successfully merging a pull request may close this issue.

feat: Better comments section PythonFreeCourse/lms
2 participants
@yammesicka @ron-huberfeld