Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to parse all worksheets in one function call #7

Merged
merged 2 commits into from
May 21, 2022

Conversation

68Kamil68
Copy link
Contributor

Added an option to parse all sheets from a workbook at once while keeping the way existing features worked untouched.

Had to modify sheet_items to a dict with sheet names as keys and sheet's objects as values.

@codecov-commenter
Copy link

Codecov Report

Merging #7 (124deec) into main (93bf731) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           39        50   +11     
=========================================
+ Hits            39        50   +11     
Impacted Files Coverage Δ
sheet2dict/main.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93bf731...124deec. Read the comment docs.

Copy link
Owner

@Pytlicek Pytlicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M 👍

@Pytlicek
Copy link
Owner

Many thanks for your contribution 👍 🙏

@Pytlicek Pytlicek merged commit d8d363b into Pytlicek:main May 21, 2022
@Pytlicek Pytlicek self-assigned this May 21, 2022
@Pytlicek Pytlicek added the enhancement New feature or request label May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants