Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter hidden_dim unused #24

Open
cheind opened this issue Feb 7, 2021 · 0 comments
Open

Parameter hidden_dim unused #24

cheind opened this issue Feb 7, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@cheind
Copy link

cheind commented Feb 7, 2021

Hey,

I was just quickly browsing through the templates when I noticed that for the Autoencoder project the argparse parameter 'hidden_dim' is unused:

https://github.com/PyTorchLightning/deep-learning-project-template/blob/faef5bbf4f3c392b9e4d71e606edaab5ce4d0aaf/project/lit_autoencoder.py#L54

I suspect this should be used by the model to define the number of hidden dimensions. The other argparse parameter is probably accounted for in the Trainer (me: new to lightning). Thanks for this useful project.

@Borda Borda added the bug Something isn't working label Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants