Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote unit testing in open research #7

Closed
edgarriba opened this issue Apr 23, 2020 · 2 comments · Fixed by #11
Closed

promote unit testing in open research #7

edgarriba opened this issue Apr 23, 2020 · 2 comments · Fixed by #11
Labels
enhancement New feature or request

Comments

@edgarriba
Copy link
Contributor

should we promote from here to provide minimal unitests ?

it's the first thing I check in research repos and usually none of them provide minimum testing, which makes me doubt about the reliability of showed results in the paper.
@Borda Borda added the enhancement New feature or request label Aug 28, 2020
@Borda
Copy link
Member

Borda commented Aug 28, 2020

I will add tests from our Sandbox

@Borda Borda changed the title [TEST] promote unit testing in open research promote unit testing in open research Aug 28, 2020
@Borda Borda linked a pull request Aug 30, 2020 that will close this issue
adding CI #11
Merged
@Borda Borda mentioned this issue Aug 30, 2020
Merged
@Borda
Copy link
Member

Borda commented Aug 30, 2020

implemented in #11

@Borda Borda closed this as completed Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adding CI Lightning-AI/deep-learning-project-template
2 participants
@edgarriba @Borda