Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "play now" button when movie card flips #10

Closed
QAZIMAAZARSHAD opened this issue Jun 1, 2021 · 34 comments · Fixed by #476
Closed

Add "play now" button when movie card flips #10

QAZIMAAZARSHAD opened this issue Jun 1, 2021 · 34 comments · Fixed by #476
Assignees
@rompyroshni31
Labels
DCP21 This issue will be considered for DCP 21 enhancement New feature or request good first issue This issue is good for first timers 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21.Points will be 10

Comments

@QAZIMAAZARSHAD
Copy link
Owner

No description provided.

@QAZIMAAZARSHAD QAZIMAAZARSHAD added enhancement New feature or request lgm-soc Hard labels Jun 1, 2021
@aum-singhal
Copy link

Hello Sir. I can work on this issue.
If possible, can you assign it to me when LGM-SOC starts

Thanks 😊

@QAZIMAAZARSHAD
Copy link
Owner Author

I'll assign you this issue when the contribution period starts from 10th June, then you can start working on this issue.

@QAZIMAAZARSHAD QAZIMAAZARSHAD mentioned this issue Jun 9, 2021
Closed
@vishalps2606
Copy link
Contributor

I would also want to contribute to this issue! Can you assign it to me?

@QAZIMAAZARSHAD
Copy link
Owner Author

I would also want to contribute to this issue! Can you assign it to me?

Go ahead,
I'll assign you this issue when the contribution period starts from 10th June, then you can start working on this issue.

@Deepak735
Copy link

Hello sir, I would like to work on this issue as an LGMSOC participant..it will be really helpful if you assign it to me...

@QAZIMAAZARSHAD
Copy link
Owner Author

Remember only the best solution will be accepted.

@aum-singhal
Copy link

Hello Sir.
I have completed this issue. Can I make a PR today or should I do it tomorrow 🤔
And please also help me with that should I make the PR in the main branch or should create my own first and then make the PR
in that branch.

Thanks for the help in advance 😊

@QAZIMAAZARSHAD
Copy link
Owner Author

QAZIMAAZARSHAD commented Jun 10, 2021 •
edited

Hello Sir.
I have completed this issue. Can I make a PR today or should I do it tomorrow 🤔
And please also help me with that should I make the PR in the main branch or should create my own first and then make the PR
in that branch.

Thanks for the help in advance 😊

I suggest you to make PR tomorrow because today I have received more than a hundred Github notifications and it will not be possible for me to review it today.

And for the other part do whatever you like. Both ways are fine.

@aum-singhal
Copy link

Okay 😄 No Problem

Thanks for the help 😊

@QAZIMAAZARSHAD QAZIMAAZARSHAD added LGMSOC21 This issue will be considered for LGM-SOC 21 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21.Points will be 10 and removed medium labels Jun 10, 2021
@aum-singhal aum-singhal mentioned this issue Jun 11, 2021
Closed
@ghost
Copy link

ghost commented Jun 11, 2021

hello sir i can work on this issue
please assign it to me

@QAZIMAAZARSHAD
Copy link
Owner Author

hello sir i can work on this issue
please assign it to me

This issue has already been resolved and will be closed soon.
Look for any other issues.

@Deepak735
Copy link

Hello sir i m still working on this issue should i continue it or not

@QAZIMAAZARSHAD
Copy link
Owner Author

Hello sir i m still working on this issue should i continue it or not

It is open for you.
But remember only the best solution will be considered.

This was referenced Jun 12, 2021
Closed
Closed
@QAZIMAAZARSHAD QAZIMAAZARSHAD changed the title Add play and download button when hovering on movie image Add "play now" button when movie card flips Jun 21, 2021
@vishalps2606
Copy link
Contributor

@aum-singhal, @vishalps2606. @Deepak735, @MEETOZA123 anyone on it?

Yes, I'm on it. But waiting for merging all pull requests. Because if any pull request is merged before mine, some code changes show some conflicts.

@QAZIMAAZARSHAD
Copy link
Owner Author

@vishalps2606 just make PR, I will merge your first if everything in your PR will be correct.

@vishalps2606
Copy link
Contributor

@vishalps2606 just make PR, I will merge your first if everything in your PR will be correct.

ok

@saimanoharhm
Copy link

@aum-singhal @vishalps2606 @Deepak735 @MEETOZA123 Any update guys.

@QAZIMAAZARSHAD QAZIMAAZARSHAD added DCP21 This issue will be considered for DCP 21 🤩 Up for Grab This issue will is not assigned ! Grab It ! labels Jul 12, 2021
@rompyroshni31
Copy link
Contributor

rompyroshni31 commented Jul 15, 2021 •
edited

Hi Sir, If you could specify that in which respective pages, I'll have to add up(if I grab this issue) the play button when the card flips.
Is it just only on the Movies page or any else too?

@QAZIMAAZARSHAD
Copy link
Owner Author

Hi Sir, If you could specify that in which respective pages, I'll have to add up(if I grab this issue) the play button when the card flips.
Is it just only on the Movies page or any else too?

In every single movie card of every page.
Like home, action, anime, fantasy, etc.

Currently, in kids, web series, and movies page the cards don't have a flip feature so exclude these pages.

@priyansh11786
Copy link
Contributor

Hello sir, Can you please elaborate regarding the play now button issue as in If one only needs to display the play now button when the card flips or Is there any additional functionality that one needs to add with it?

@QAZIMAAZARSHAD
Copy link
Owner Author

Hello sir, Can you please elaborate regarding the play now button issue as in If one only needs to display the play now button when the card flips or Is there any additional functionality that one needs to add with it?

No just add the PlayNow button below the trailer button.

@rompyroshni31
Copy link
Contributor

rompyroshni31 commented Jul 19, 2021 •
edited

@QAZIMAAZARSHAD Hey Sir, I would like to work on this issue. Please assign me this.

@QAZIMAAZARSHAD
Copy link
Owner Author

@QAZIMAAZARSHAD Hey Sir, I would like to work on this issue. Please assign me this.

Under DCP or LGMSoC?

@rompyroshni31
Copy link
Contributor

Under Devincept(Dcp).

@QAZIMAAZARSHAD QAZIMAAZARSHAD removed LGMSOC21 This issue will be considered for LGM-SOC 21 🤩 Up for Grab This issue will is not assigned ! Grab It ! labels Jul 19, 2021
@rompyroshni31
Copy link
Contributor

rompyroshni31 commented Jul 21, 2021 •
edited

Hello Sir,
Please check this out https://rompyroshni31.github.io/Movie-Streaming-Website/
I've added a play button to every flip card present on the pages. Is it okay?

@utkarsh-ub
Copy link

Hello Sir,
Please check this out https://rompyroshni31.github.io/Movie-Streaming-Website/
I've added a play button to every flip card present on the pages. Is it okay?

@rompyroshni31 make the play now button similar to the trailer button and also add a play icon before it.Positioning is all right 👍

@QAZIMAAZARSHAD
Copy link
Owner Author

Hello Sir,
Please check this out https://rompyroshni31.github.io/Movie-Streaming-Website/
I've added a play button to every flip card present on the pages. Is it okay?

@rompyroshni31 one more important thing, your repo is not updated many features are missing.
Before starting to work on any issue always keep your repo up to date.
Fetch upstream.

@rompyroshni31
Copy link
Contributor

Hello, Please check it's completed. Sorry for the delay, I had a sessional college test.
https://rompyroshni31.github.io/Movie-Streaming-Website/

@QAZIMAAZARSHAD
Copy link
Owner Author

Hello, Please check it's completed. Sorry for the delay, I had a sessional college test.
https://rompyroshni31.github.io/Movie-Streaming-Website/

check one piece in the anime section.

Your repo is not updated. Fetch upstream.

Check newly updated movies in documentaries, war. and horror page.

@QAZIMAAZARSHAD
Copy link
Owner Author

Update then make PR.

@rompyroshni31 rompyroshni31 mentioned this issue Jul 26, 2021
Merged
7 tasks
@QAZIMAAZARSHAD QAZIMAAZARSHAD added 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21.Points will be 10 and removed 🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21.Points will be 5 labels Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rompyroshni31 rompyroshni31

Labels
DCP21 This issue will be considered for DCP 21 enhancement New feature or request good first issue This issue is good for first timers 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21.Points will be 10
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Play Button on every flip card present on the webpages. rompyroshni31/Movie-Streaming-Website
8 participants
@QAZIMAAZARSHAD @rompyroshni31 @aum-singhal @vishalps2606 @saimanoharhm @utkarsh-ub @Deepak735 @priyansh11786