Add Zurich Instruments drivers #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new drivers are based on the external package zhinst-qcodes, this commit add only stubs to import them within Qcodes. Support for MFLI, UHFLI, UHFQA, and HDAWG instrument is added.
The new drivers depends on the external package zhinst-qcodes. With this modification it can be installed togheter with Qcodes as extra package with 'pip install qcodes[ZurichInstrument]'
Codecov Report
@@ Coverage Diff @@
## master #2025 +/- ##
==========================================
+ Coverage 71.11% 71.15% +0.03%
==========================================
Files 145 149 +4
Lines 19489 19515 +26
==========================================
+ Hits 13860 13886 +26
Misses 5629 5629 |
jenshnielsen
reviewed
Jun 2, 2020
jenshnielsen
approved these changes
Jun 3, 2020
|
@astafan8 Please have a look |
astafan8
approved these changes
Jun 3, 2020
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for Zurich Instruments devices as drivers inside of QCodes.
The actual implementation is in https://github.com/zhinst/zhinst-qcodes/ as described in
https://blogs.zhinst.com/andrea/2020/05/24/control-your-measurements-with-qcodes-and-labber/
Here we propose to add stubs in Qcodes to help user to find and install such drivers.
We propose deprecation of the existing ZIUHF, since its functionality is replaced by this PR.
A new optional installation option, 'ZurichInstruments' is introduced. That add the package zhinst-qcodes as optional dependency of Qcodes, if the user wish so.
@jenshnielsen