Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some of the warnings triggered by numpy 1.19 #2239

Merged

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Oct 5, 2020

Only use instantiable types as dtypes when creating arrays. Using the non concrete types triggers a warning and will be an error in the future

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #2239 into master will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##           master    #2239   +/-   ##
=======================================
  Coverage   71.85%   71.85%           
=======================================
  Files         154      154           
  Lines       20647    20655    +8     
=======================================
+ Hits        14835    14841    +6     
- Misses       5812     5814    +2     

qcodes/utils/validators.py Outdated Show resolved Hide resolved
@jenshnielsen jenshnielsen merged commit 83db01e into microsoft:master Oct 14, 2020
@jenshnielsen jenshnielsen deleted the numpy_119_fix_dtype_warnings branch October 14, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants