Fix sequnce validator for with sorted = True #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to work correctly with other sequence types than list
jenshnielsen
force-pushed
the
fix_sorted_validator
branch
from
76f5d4c
to
0052e1f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2271 +/- ##
==========================================
+ Coverage 71.83% 71.85% +0.01%
==========================================
Files 154 154
Lines 20647 20647
==========================================
+ Hits 14832 14835 +3
+ Misses 5815 5812 -3 |
astafan8
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorted(Sequence) always returns a list so the previous comparison would be incorrect if the input sequence is not a list.
This fixes that by always casting to a tuple on both sides.
Also add some basic tests for the sequence validator that was missing