Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to allow pyvisa 1.11 dependency #2304

Merged
merged 35 commits into from Oct 20, 2020
Merged

Conversation

trevormorgan
Copy link
Contributor

@trevormorgan trevormorgan commented Oct 19, 2020

Several updates are needed to use pyvisa 1.11 in qcodes.

  • import visa is deprecated in favor of import pyvisa as visa
  • pyvisa backend using of - is deprecated
  • write_raw low-level interface to visa_handle.write update needed to to changes in pyvisa event handler
    • This section could use some more eyes as I think there should be a smarter way to handle write error events.

Closes #2184

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #2304 into master will decrease coverage by 0.00%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master    #2304      +/-   ##
==========================================
- Coverage   71.75%   71.75%   -0.01%     
==========================================
  Files         156      156              
  Lines       20732    20736       +4     
==========================================
+ Hits        14877    14879       +2     
- Misses       5855     5857       +2     

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trevormorgan so this PR works with both pyvisa 1.11 and 1.10.x?

qcodes/instrument/visa.py Outdated Show resolved Hide resolved
@astafan8 astafan8 added this to the 0.19.0 milestone Oct 19, 2020
@jenshnielsen jenshnielsen reopened this Oct 20, 2020
@jenshnielsen jenshnielsen merged commit bc6c638 into master Oct 20, 2020
@jenshnielsen jenshnielsen deleted the pyvisa_1.11_fixes branch October 20, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants