New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to allow pyvisa 1.11 dependency #2304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
pyvisa_1.11_fixes
branch
from
October 19, 2020 07:46
c203006
to
4de8b59
Compare
Codecov Report
@@ Coverage Diff @@
## master #2304 +/- ##
==========================================
- Coverage 71.75% 71.75% -0.01%
==========================================
Files 156 156
Lines 20732 20736 +4
==========================================
+ Hits 14877 14879 +2
- Misses 5855 5857 +2 |
fixes typing issue
astafan8
reviewed
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trevormorgan so this PR works with both pyvisa 1.11 and 1.10.x?
…into pyvisa_1.11_fixes
astafan8
approved these changes
Oct 19, 2020
trevormorgan
commented
Oct 19, 2020
astafan8
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several updates are needed to use pyvisa 1.11 in qcodes.
import visa
is deprecated in favor ofimport pyvisa as visa
-
is deprecatedpyvisa_sim
. This PR needs to land before this one for testing to pass. https://github.com/QCoDeS/pyvisa-sim/pull/5write_raw
low-level interface tovisa_handle.write
update needed to to changes in pyvisa event handlerCloses #2184