Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update old driver notebooks (Agilent 34400A) #2377

Merged
merged 14 commits into from Apr 9, 2021

Conversation

Akshita07
Copy link
Contributor

@Akshita07 Akshita07 commented Oct 29, 2020

Fixes legacy code use in old example driver notebooks.

Changes proposed in this pull request:

  • Remove Loop usage in Agilent 34400A notebook
  • Use get_idn method for getting information in Oxford Triton notebook

To do:

  • Test Agilent 34400A notebook with instrument

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #2377 (0c9b6c9) into master (f688fe3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2377   +/-   ##
=======================================
  Coverage   65.36%   65.36%           
=======================================
  Files         207      207           
  Lines       27978    27978           
=======================================
  Hits        18288    18288           
  Misses       9690     9690           

@jenshnielsen
Copy link
Collaborator

For the Agilent 34400A notebook I think we should:

  • Get rid of that Timer class. It does not really have anything to do with this instrument and just creates more confusion.
  • Only create one station.
  • Write a bit of text explaining what we are doing.

@jenshnielsen jenshnielsen changed the title Update old driver notebooks Update old driver notebooks (Agilent 34400A) Jan 20, 2021
@astafan8 astafan8 added the docs Related to docs improvements label Feb 11, 2021
@Akshita07 Akshita07 marked this pull request as ready for review March 22, 2021 15:23
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the diagram and the explanations!

@Akshita07 Akshita07 merged commit c121578 into microsoft:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to docs improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants