Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant performance improvement in Tektronix5014 driver #2910

Merged

Conversation

sldesnoo-Delft
Copy link
Contributor

Changes proposed in this pull request:

  • For the conversion of 4 waveforms with 1e6 Sa the time is reduced from 890 ms to 310 ms.
  • The change in _pack_waveform gives a reduction of 180 ms.
  • The change in _pack_record gives a reduction of 400 ms.

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #2910 (8c16444) into master (1bc4723) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2910   +/-   ##
=======================================
  Coverage   65.31%   65.31%           
=======================================
  Files         209      209           
  Lines       28037    28037           
=======================================
  Hits        18312    18312           
  Misses       9725     9725           

@jenshnielsen jenshnielsen added this to the 0.25.0 milestone Apr 14, 2021
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenshnielsen i think this looks good now, shall we merge?

@jenshnielsen jenshnielsen merged commit bd6b67c into microsoft:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants