Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly use rundescriber to create run when exporting datasets to a new database file #3956

Merged
merged 15 commits into from Feb 24, 2022
Merged

Directly use rundescriber to create run when exporting datasets to a new database file #3956

merged 15 commits into from Feb 24, 2022

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Feb 23, 2022 •
edited

Resolves #3953 by ensuring that the full run description is copied to the new dataset

@jenshnielsen jenshnielsen added this to the 0.33.0 milestone Feb 23, 2022
@codecov
Copy link

codecov bot commented Feb 23, 2022 •
edited

Codecov Report

Merging #3956 (ca2ae42) into master (989be87) will decrease coverage by 0.00%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master    #3956      +/-   ##
==========================================
- Coverage   65.82%   65.82%   -0.01%     
==========================================
  Files         228      228              
  Lines       31428    31442      +14     
==========================================
+ Hits        20688    20696       +8     
- Misses      10740    10746       +6

@jenshnielsen jenshnielsen force-pushed the dataset/create_run_from_description branch from 730719a to 75b5977 Compare February 23, 2022 14:46
@jenshnielsen jenshnielsen changed the title WIP start making create_run take description Directly use rundescriber to create run when exporting Feb 23, 2022
@jenshnielsen
Copy link
Collaborator Author

jenshnielsen commented Feb 23, 2022 •
edited 

qcodes/tests/dataset/test_sqlite_base.py::test_get_dependents
qcodes/tests/dataset/test_sqlite_base.py::test_atomic_creation
qcodes/tests/dataset/test_sqlite_base.py::test_atomic_creation
  /home/runner/work/Qcodes/Qcodes/qcodes/dataset/sqlite/queries.py:1718: UserWarning: passing parameters to create_run is deprecated and will be removed in the future
    "passing parameters to create_run is deprecated and will "

EDIT Fixed

astafan8
astafan8 approved these changes Feb 23, 2022
View reviewed changes
qcodes/dataset/descriptions/rundescriber.py Outdated Show resolved Hide resolved
qcodes/dataset/sqlite/queries.py Outdated Show resolved Hide resolved
qcodes/tests/dataset/test_database_extract_runs.py Show resolved Hide resolved
@astafan8 astafan8 changed the title Directly use rundescriber to create run when exporting Directly use rundescriber to create run when exporting datasets to a new database file Feb 23, 2022
@jenshnielsen jenshnielsen force-pushed the dataset/create_run_from_description branch from 9437e33 to 5022019 Compare February 24, 2022 08:50
@jenshnielsen
Copy link
Collaborator Author

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 24, 2022

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@jenshnielsen jenshnielsen merged commit 72090cb into microsoft:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.

The shape of a dataset is not preserved when a run is exported to another database
2 participants
@jenshnielsen @astafan8