Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legacy Qcodes dataset to xarray conversion #4011

Merged
merged 11 commits into from Mar 16, 2022
Merged

Fix legacy Qcodes dataset to xarray conversion #4011

merged 11 commits into from Mar 16, 2022

Conversation

peendebak
Copy link
Contributor

@peendebak peendebak commented Mar 10, 2022 •
edited

This PR improves the qcodes to xarray conversion:

@jenshnielsen @astafan8

@codecov
Copy link

codecov bot commented Mar 10, 2022 •
edited

Codecov Report

Merging #4011 (a752fa2) into master (e5e233f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4011   +/-   ##
=======================================
  Coverage   65.83%   65.84%           
=======================================
  Files         233      233           
  Lines       31495    31498    +3     
=======================================
+ Hits        20736    20739    +3     
  Misses      10759    10759

@astafan8
Copy link
Contributor

@peendebak could you please add a newsfragment to the PR ? see the last bullet point in this section about pull requests https://qcodes.github.io/Qcodes/community/contributing.html#pull-requests

@peendebak
Copy link
Contributor Author

@astafan8 Done

@peendebak could you please add a newsfragment to the PR ? see the last bullet point in this section about pull requests https://qcodes.github.io/Qcodes/community/contributing.html#pull-requests

Done

@astafan8 astafan8 changed the title Fix Qcodes to xarray conversion Fix legacy Qcodes dataset to xarray conversion Mar 16, 2022
astafan8
astafan8 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 16, 2022

Build succeeded:

@bors bors bot merged commit 4e92280 into microsoft:master Mar 16, 2022
@peendebak peendebak deleted the fix/qcodes_xarray_conversion branch March 16, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conversion from xarray dataset fails for transposed array
3 participants
@peendebak @astafan8 @eendebakpt