Extend do_nd with option to perform "Parallel sweeps" #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
reviewed
Jun 29, 2022
jenshnielsen
force-pushed
the
dond_multiparameter
branch
2 times, most recently
from
ae97565
to
70048df
Compare
jenshnielsen
force-pushed
the
dond_multiparameter
branch
5 times, most recently
from
7f6da17
to
4f37801
Compare
jenshnielsen
force-pushed
the
dond_multiparameter
branch
from
4f37801
to
2743955
Compare
jenshnielsen
force-pushed
the
dond_multiparameter
branch
7 times, most recently
from
cd54135
to
971e649
Compare
jenshnielsen
force-pushed
the
dond_multiparameter
branch
2 times, most recently
from
4991878
to
2d01ad9
Compare
Codecov Report
@@ Coverage Diff @@
## master #4325 +/- ##
==========================================
+ Coverage 68.28% 68.32% +0.04%
==========================================
Files 339 339
Lines 31794 31990 +196
==========================================
+ Hits 21710 21857 +147
- Misses 10084 10133 +49 |
basnijholt
reviewed
Sep 8, 2022
jenshnielsen
force-pushed
the
dond_multiparameter
branch
2 times, most recently
from
ff180aa
to
59f4211
Compare
basnijholt
reviewed
Sep 13, 2022
jenshnielsen
force-pushed
the
dond_multiparameter
branch
3 times, most recently
from
a7bc91c
to
e971d8a
Compare
It is now an error to supply both grouped parameters and a dataset_mapping but dataset_mapping can be supplied without groups
jenshnielsen
force-pushed
the
dond_multiparameter
branch
from
81eb4bb
to
e110b2e
Compare
jenshnielsen
commented
Sep 29, 2022
jenshnielsen
commented
Sep 29, 2022
jenshnielsen
commented
Sep 29, 2022
jenshnielsen
commented
Sep 29, 2022
astafan8
approved these changes
Sep 29, 2022
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
jenshnielsen
force-pushed
the
dond_multiparameter
branch
from
acd52e4
to
ed9e189
Compare
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process refactor Sweeps and Measurements to be a bit more modular
closes #4366 by refactoring the setpoint logic to generate the input type.