driver/AWG70000A broadbean compatibility #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makeSEQXFile should not take .wfmx files as its input, since that creates a dependence on having this module to be able to generate a valid input for makeSEQXFile
3 tasks
| flat_wfmxs += [AWG70000A.makeWFMXFile(wfm, amplitude) | ||
| for wfm in wfm_lst] | ||
|
|
||
| # flat_wfmxs = [wfmx for lst in wfms for wfmx in lst] |
Codecov Report
@@ Coverage Diff @@
## master #911 +/- ##
=======================================
Coverage 78.63% 78.63%
=======================================
Files 33 33
Lines 4536 4536
=======================================
Hits 3567 3567
Misses 969 969 |
…amHPNielsen/Qcodes into driver/AWG70000A_broadbean_changes
|
Apart from the commented out line that should be removed this looks fine |
…amHPNielsen/Qcodes into driver/AWG70000A_broadbean_changes
…amHPNielsen/Qcodes into driver/AWG70000A_broadbean_changes
giulioungaretti
pushed a commit
that referenced
this pull request
Dec 13, 2017
Author: William H.P. Nielsen <whpn@mailbox.org>
driver/AWG70000A broadbean compatibility (#911)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the AWG70000A .seqx file generation play nicely with broadbean, some code restructuring and slight API changes are needed in the AWG70000A driver. This PR introduces those.
Changes proposed in this pull request:
makeSEQXFiletake numpy arrays rather than.wfmxfiles as inputThere is a parallel PR in broadbean about this: QCoDeS/broadbean#47.
@jenshnielsen