New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Dataset documentation #992
Merged
WilliamHPNielsen
merged 311 commits into
microsoft:master
from
jenshnielsen:dataset_docs
Mar 20, 2018
Merged
[WIP] Dataset documentation #992
WilliamHPNielsen
merged 311 commits into
microsoft:master
from
jenshnielsen:dataset_docs
Mar 20, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note to self and future reader: an underscore appended to a function name denotes a function whose side-effects needs to be committed!
That is: a dataset needs an exp_id. If it's not passed to the new_dataset then we use the last exp_id.
Codecov Report
@@ Coverage Diff @@
## master #992 +/- ##
=======================================
Coverage 78.96% 78.96%
=======================================
Files 45 45
Lines 6445 6445
=======================================
Hits 5089 5089
Misses 1356 1356 |
Fixing a few typos in dataset_design.rst
WilliamHPNielsen
approved these changes
Mar 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an awesome start.
giulioungaretti
pushed a commit
that referenced
this pull request
Mar 20, 2018
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com> [WIP] Dataset documentation (#992)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.