Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy CUDA implementation phasing out plan #3856

Closed
2 tasks done
ye-luo opened this issue Feb 19, 2022 · 3 comments
Closed
2 tasks done

legacy CUDA implementation phasing out plan #3856

ye-luo opened this issue Feb 19, 2022 · 3 comments

Comments

@ye-luo
Copy link
Contributor

ye-luo commented Feb 19, 2022

As the batched drivers + OpenMP offload catches up in performance, we need to think about how to phasing out the legacy CUDA implementation. There is no exact timeline, phasing out the codes will be in stages.

Here is my proposal.

  • delete WFOpt related legacy CUDA code. Would like to do this relatively soon as this slows down making better WFOpt drivers. Remove WFOpt support in legacy CUDA #3984
  • delete VMC/DMC, namely all the result. This will depends on the need to keep the code and difficulty to keep the code around.

If you are using the GPU code but found batched drivers + OpenMP offload doesn't cover you need, please let us know. See #3508

@williamfgc
Copy link
Contributor

Not directly related to any feature in particular, but C++14 has a deprecated attribute. Having it for any feature for a "reasonable" amount of time (depending on need) will give people enough time to be aware and adapt.

@prckent
Copy link
Contributor

prckent commented Feb 21, 2022

One consideration is that it is convenient to have the legacy CUDA implementation around since this is what the CORAL benchmark and therefore several machine acceptances rely on. If we remove the implementation completely from the latest version / development version then we might have to backport e.g. CMake and other fixes to an older released version. However we certainly don't need to keep the legacy CUDA optimizer paths around.

A trickier topic is our strategy for pushing/encouraging people to use the batched drivers and get sufficient feedback on them prior to dropping them or renaming the inputs etc.

@ye-luo
Copy link
Contributor Author

ye-luo commented Feb 3, 2023

Legacy CUDA has been removed from the code base #4431

@ye-luo ye-luo closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants