Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

关键参数数量关系的约束 #328

Open
blackpainter opened this issue Sep 2, 2019 · 3 comments
Open

关键参数数量关系的约束 #328

blackpainter opened this issue Sep 2, 2019 · 3 comments

Comments

@blackpainter
Copy link
Member

qos有通过决议修改参数的功能,但一些参数间不符合一定数量关系约束就容易出问题,有必要整理出这些约束条件,在修改参数的validate方法中进行逻辑语义级别的约束

@imuge
Copy link
Contributor

imuge commented Sep 16, 2019

stake:

  • max_validator_cnt > 0
  • voting_status_len > 0
  • voting_status_least > 0, voting_status_least <= voting_status_len
  • survival_secs > 0
  • unbond_frozen_height > 0
  • max_evidence_age >= 0
  • slash_fraction_double_sign [0, 1]
  • slash_fraction_downtime [0, 1]

distribution:

  • proposer_reward_rate [0, 1]
  • community_reward_rate [0, 1]
  • delegator_income_period_height > 0
  • gas_per_unit_cost > 0

gov:

  • min_deposit > 0
  • min_proposer_deposit_rate [0, 1]
  • max_deposit_period > 0
  • voting_period > 0
  • quorum [0, 1]
  • threshold [0, 1]
  • veto [0, 1]
  • penalty [0, 1]
  • burn_rate [0, 1]

@blackpainter
Copy link
Member Author

blackpainter commented Sep 16, 2019

stake:
unbond_frozen_height > delegator_income_period_height
unbond_frozen_height > max_evidence_age

gov:
unbond_frozen_height > voting_period (#274 如果不投票决定则不需要此项检查)

@blackpainter
Copy link
Member Author

有数量关系制约的两个参数同时提交change_parameter的proposal该如何检查?是否要与潜在的、变化后的值也进行比较?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants