Some corrections for MRAF in the package #64
Replies: 2 comments
-
Hi @Shuyun1247, Thank you for your interest in slmsuite! Could you provide a test case that results in a bug? Your fix to 1 makes me suspicious that there's some versioning or package inconsistency with numpy/cupy transformations (or it could just be a bug). In similar cases, I've added failsafes so the code works on both versions. Your fix to 2 looks reasonable. This is definitely a bug/issue, so I'm moving this discussion to Issues. The addition of 3D spots #41 in the next release is going to mess with a lot of the internals of Thanks for this feedback! Let us know if you find anything else similar to this (every bug reported is a bug squashed), or if there are any features of particular interest. Best, |
Beta Was this translation helpful? Give feedback.
-
Hello,
I've been using your package, and it's been working great for me. However, I encountered some issues when using the MRAF method in your code, specifically when setting the signal region be a rectangular "null_region". I've identified some areas in
algorithm.py
that, upon modification, resolve these issues. Here are the changes I suggest:Modification in
ijcam_to_knmslm
function:In
algorithms.py
, find the definition of the functionijcam_to_knmslm
. Before the affine transformation, add the lineb = b.reshape(-1)
to ensure the correct shape forb
.Original:
Modified:
Modification related to
null_knm
andnull_region_knm
:Find the following section in
algorithms.py
and modify it as follows to account for bothnull_knm
andnull_region_knm
.Original:
Modified:
...
I'm not entirely sure if I was using the
SpotHologram
incorrectly, but after making these corrections, the method worked properly for both "null_vector" and "null_region" for us. I hope these suggestions are helpful. Let me know if you need any more details or if there are any concerns.Thank you!
Beta Was this translation helpful? Give feedback.
All reactions