Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wavefront calibration upgrade #43

Closed
wants to merge 3 commits into from
Closed

Wavefront calibration upgrade #43

wants to merge 3 commits into from

Conversation

ichristen
Copy link
Collaborator

See #42 .

@ichristen ichristen requested review from cpanuski and tpr0p May 23, 2023 17:04
@ichristen ichristen linked an issue May 23, 2023 that may be closed by this pull request
Wavefront calibration fit & correct the center of the spots array #42
Open
cpanuski
cpanuski requested changes May 28, 2023
View reviewed changes
Copy link
Collaborator

@cpanuski cpanuski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See bugfixes and rotation additions on sim branch (commit d9b15e2 and one after).

@ichristen
Copy link
Collaborator Author

Closed as this was already merged into sim #52 .

@ichristen ichristen closed this Aug 22, 2023
@ichristen ichristen deleted the wavefront_calibration_upgrade branch May 1, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanuski cpanuski cpanuski requested changes

@tpr0p tpr0p Awaiting requested review from tpr0p

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wavefront calibration fit & correct the center of the spots array
2 participants
@ichristen @cpanuski