Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored SLM phase includes phase_correction #46

Open
ichristen opened this issue Jun 22, 2023 · 0 comments
Open

Stored SLM phase includes phase_correction #46

ichristen opened this issue Jun 22, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@ichristen
Copy link
Collaborator

The phase attribute of the SLM is overwritten every time slm.write() is used. When phase_correct=True (default), the phase_correction (if not None) is added to this. However, if the user stores the phase with stored = slm.phase.copy() and tries to slm.write(stored), the phase_correction will effectively be applied twice and might lead to unexpected results. Perhaps the sorted phase should not include the phase_correction?

@ichristen ichristen added enhancement New feature or request question Further information is requested labels Jun 22, 2023
@ichristen ichristen self-assigned this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant