Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up true 2D support for cameras/SLMs with non-square pixels. #50

Open
cpanuski opened this issue Aug 13, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@cpanuski
Copy link
Collaborator

Many returns (e.g. computed PSF sizes) are averages of the results in x and y dimensions; results should instead be vectors with results for each dimension and handled accordingly.

@ichristen
Copy link
Collaborator

(We discussed separately and noted that the full picture would actually be a 2x2 matrix including shear. The question is whether to add this now or add it reactively when someone needs it.)

@ichristen ichristen added the enhancement New feature or request label Aug 16, 2023
@ichristen ichristen changed the title Clean up true 2D support for non-square SLMs Clean up true 2D support for cameras/SLMs with non-square pixels. Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants