Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataRay Camera support #51

Open
dwgong opened this issue Aug 16, 2023 · 1 comment
Open

DataRay Camera support #51

dwgong opened this issue Aug 16, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dwgong
Copy link

dwgong commented Aug 16, 2023

Hi,

We really like you package. But we are using a lot of DataRay cameras in the lab. So I'm wondering if it's possible that you can support it in the future

@ichristen
Copy link
Collaborator

Hi @dwgong ,

Glad to hear the package is useful!

Contributions to add new hardware are welcome! There are a few ways we could go about this:

  • You could send us sample code for what you've been using to connect to DataRay cameras and we can format it as an slmsuite.hardware.camera. This is a template for what abstract methods need to be filled to get a functional camera interface.
  • You can format the above and send it to us for review via GitHub pull request.

Whatever the case, it would be good to test the code on hardware before adding it to main. We unfortunately do not have any DataRay cameras and thus cannot test on hardware ourselves.

Best,
Ian

@ichristen ichristen changed the title Camera support DataRay Camera support Aug 16, 2023
@ichristen ichristen added enhancement New feature or request good first issue Good for newcomers labels Aug 16, 2023
@ichristen ichristen mentioned this issue Aug 28, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants