Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyglet 2.0.0 #7

Open
tpr0p opened this issue Nov 3, 2022 · 3 comments
Open

pyglet 2.0.0 #7

tpr0p opened this issue Nov 3, 2022 · 3 comments
Assignees
Labels
bug Something isn't working r0.0.3 Planned part of the 0.0.3 release

Comments

@tpr0p
Copy link
Member

tpr0p commented Nov 3, 2022

pyglet updated to 2.0.0 on 11/01/2022 which caused breaking changes for screen-mirrored slms. We should find a stable way to version the package's dependencies. See about doing this in setup.py, which notes dependencies for pip install git+<>. Also we should fix the screen mirrored slms to use new version of pyglet. For now one can do
pip install pyglet==1.5.27

@ichristen ichristen added the bug Something isn't working label Nov 3, 2022
@ichristen
Copy link
Collaborator

@tpr0p , if you want to fix it, go for it, but I can tackle it in a week or so (along with the pygletcamera branch, commit 381af3e).

@ichristen ichristen self-assigned this Jan 16, 2023
@ichristen ichristen mentioned this issue Jan 25, 2023
33 tasks
@ichristen
Copy link
Collaborator

I was lurking in slmpy's issues thread. If we get back to this, we should test other corner cases which have caused issues previously. In particular:

@ichristen ichristen mentioned this issue Aug 28, 2023
13 tasks
@ichristen ichristen mentioned this issue Mar 7, 2024
@ichristen ichristen added the r0.0.2 Planned part of the 0.0.2 release label Mar 10, 2024
@ichristen
Copy link
Collaborator

Downgrading the pyglet version to 1.4.10 helped resolve a threading issue in #26 . In slmsuite v0.0.3, we should do the full upgrade to pyglet 2+.

@ichristen ichristen added r0.0.3 Planned part of the 0.0.3 release and removed r0.0.2 Planned part of the 0.0.2 release labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working r0.0.3 Planned part of the 0.0.3 release
Projects
None yet
Development

No branches or pull requests

2 participants