Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface module cannot converge after BioSTEAM/Thermosteam updates (test temporarily disabled) #35

Closed
yalinli2 opened this issue Jun 14, 2023 · 6 comments

Comments

@yalinli2
Copy link
Member

yalinli2 commented Jun 14, 2023

See details in the failed test on QSDsan:
https://github.com/QSD-Group/QSDsan/actions/runs/5235788112

Not yet sure what happened, will try to fix it (or wait till it miraculously fixes itself, 🙄), temporarily disabled the test for the interface module for now.

@hccroll
Copy link

hccroll commented Jun 19, 2023

Hello @yalinli2 I am new to QSDsan/EXPOsan and this error appears to be preventing me from installing the package. Do know if there is a work-around for now? Thanks in advance.

@yalinli2
Copy link
Member Author

@hccroll interesting, I didn't expect this to be preventing installation, can you post the entirety of the error here?

@hccroll
Copy link

hccroll commented Jun 20, 2023

Using Colab python 3.10.12:

!pip install exposan

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
tensorflow 2.12.0 requires numpy<1.24,>=1.22, but you have numpy 1.24.3 which is incompatible.

!pip install numpy==1.22

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
librosa 0.10.0.post2 requires numpy!=1.22.0,!=1.22.1,!=1.22.2,>=1.20.3, but you have numpy 1.22.0 which is incompatible.
thermosteam 0.35.0 requires numpy>=1.24.2, but you have numpy 1.22.0 which is incompatible.

When I saw this as a recent issue thanks to the Themesteam updates, I assumed that they must have updated their requirement for numpy at the same time. This may be an incorrect assumption, but it seems like a strange coincidence. Currently looking to see if forcing an older version of thermosteam fixes the issue.

@yalinli2
Copy link
Member Author

@hccroll oh it's actually unrelated haha, you can see the reason for numpy version requirement here: #34
chaospy, one of biosteam's dependency, started having problems with numpy at some point and seems to be fixed with the newer version.

Since tensorflow (it isn't a dependency package of biosteam/thermosteam or qsdsan/exposan) requires older numpy, hence the conflicts.

You could try force installing the newer numpy, if it does cause problem for tensorflow or other packages you use, it'll be best to have different environments to management them

@yalinli2
Copy link
Member Author

As an update, it's still not converging, maybe the mock system we designed isn't good at all... we can use BSM2 config for testing when it's done.

@yalinli2
Copy link
Member Author

Closing this issue since the interface module has been updated to bsm2, see #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants