Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #52

Closed
yalinli2 opened this issue Feb 24, 2022 · 3 comments
Closed

Improve test coverage #52

yalinli2 opened this issue Feb 24, 2022 · 3 comments
Assignees
@joyxyz1994 @yalinli2
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@yalinli2
Copy link
Member

Currently (Feb 24, 2022) only a bit over 50% of the package is covered by test, let's aim to get it up to ~80%.

See the codecov report for priorities. Adding doc examples would probably be a good solution way to deal with it as it also helps users.

I'll include our tutorial examples in the test after dyn-enabled BioSTEAM is out, hopefully that will also bump up coverage.
@yalinli2 yalinli2 added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 24, 2022
@yalinli2
Copy link
Member Author

Also, would be good to include EXPOsan's tests (currently only run locally), include READMEs

@yalinli2
Copy link
Member Author

yalinli2 commented Mar 1, 2022

EXPOsan's tests are now included in QSDsan

@yalinli2 yalinli2 mentioned this issue Jul 7, 2022
Closed
4 tasks
@yalinli2
Copy link
Member Author

yalinli2 commented Jul 7, 2022

This is largely done for existing units and I'll add tests for the new units when pulling in modules from the gates branch, see #70

@yalinli2 yalinli2 closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joyxyz1994 joyxyz1994

@yalinli2 yalinli2

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joyxyz1994 @yalinli2