Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#update for accountpro & update to 1.6.8 #1345

Merged
merged 1 commit into from Nov 9, 2019
Merged

#update for accountpro & update to 1.6.8 #1345

merged 1 commit into from Nov 9, 2019

Conversation

yutiansut
Copy link
Owner

QUANTAXIS PR 😇

感谢您对于QUANTAXIS的项目的参与~ 🛠请在此完善一下最后的信息~

注意

  • 如果非第一次fork, 请先将quantaxis 库的内容PR进您的项目进行更新, 然后再执行对于quantaxis的pr
  • 请完善CHANGELOG再进行PR

PR前必看

请使用如下代码对要PR的代码进行格式化:

qa的 yapf格式也是从vnpy那拿来的 参见 https://github.com/vnpy/vnpy/blob/v2.0-DEV/.style.yapf

使用以下代码来格式化

pip install https://github.com/google/yapf/archive/master.zip
yapf -i --style .style.yapf <file>

🛠该PR主要解决的问题🛠:

作者信息:
时间:

@pep8speaks
Copy link

Hello @yutiansut! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 229:13: E722 do not use bare 'except'
Line 377:80: E501 line too long (104 > 79 characters)
Line 378:80: E501 line too long (82 > 79 characters)
Line 381:80: E501 line too long (104 > 79 characters)
Line 382:80: E501 line too long (83 > 79 characters)

@yutiansut yutiansut merged commit b4daba9 into yutiansut:master Nov 9, 2019
Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants