jim-payments maybe bridge not working 100%? qb script to qbx

[D3monkat]

Summary

bridge not working

Reproduction

when using jim-payments and using jim-catcafe or trying to use the cash register command it will throw an error when trying to locate nearest players.

Expected behavior

should pull the closest players and offer to charge the player

Actual behavior

error codes:
[ script:jim-payments] SCRIPT ERROR: @jim-payments/server/server.lua:246: attempt to index a nil value (local 'P')
[ script:jim-payments] > TriggerCallback (@qbx_core/bridge/qb/server/main.lua:81)
[ script:jim-payments] > handler (@qbx_core/bridge/qb/server/main.lua:43)
[ script:qbx_core] SCRIPT ERROR: error object is not a string

Additional context

No response

Last Updated

today

Custom Resources

jim-payments

Resource Rename

no

[Manason]

Can you copy and paste the calling line? @jim-payments/server/server.lua:246

[CarlBishop]

local P = QBCore.Functions.GetPlayer(v) onlineList[#onlineList+1] = { value = tonumber(v), text = "["..v.."] - "..P.PlayerData.charinfo.firstname..' '..P.PlayerData.charinfo.lastname } end

[Manason]

local P = QBCore.Functions.GetPlayer(v) onlineList[#onlineList+1] = { value = tonumber(v), text = "["..v.."] - "..P.PlayerData.charinfo.firstname..' '..P.PlayerData.charinfo.lastname } end

What is the value of v? Could you print it or show additional preceding lines?

[CarlBishop]

I'm only helping, I cannot reproduce the issue since I guess it happens only when a player is billing another player and I do not have any server with players... so the original issue poster should reply.

By the way this is the server callback:

QBCore.Functions.CreateCallback('jim-payments:MakePlayerList', function(source, cb)
	local onlineList = {}
	for _, v in pairs(QBCore.Functions.GetPlayers()) do
		local P = QBCore.Functions.GetPlayer(v)
		onlineList[#onlineList+1] = { value = tonumber(v), text = "["..v.."] - "..P.PlayerData.charinfo.firstname..' '..P.PlayerData.charinfo.lastname  }
	end
	cb(onlineList)
end)

I guess the nil value is because there was no nearby player, because this code lack for check about nul value, it should contain:

	for _, v in pairs(QBCore.Functions.GetPlayers()) do
		local P = QBCore.Functions.GetPlayer(v)
		if P ~= nil then
			onlineList[#onlineList+1] = { value = tonumber(v), text = "["..v.."] - "..P.PlayerData.charinfo.firstname..' '..P.PlayerData.charinfo.lastname  }
		end
	end

[D3monkat]

when i go to bill another player. that gets called but it throws the error above.

[Manason]

I suspect #215 should fix this. Can you pull latest commit and try again?