Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After breaking blocks, sometimes clouds render in front of blocks #4

Closed
AeiouEnigma opened this issue Jan 4, 2022 · 12 comments
Closed

Comments

@AeiouEnigma
Copy link
Contributor

This is a bizarre, inconsistent issue that's a bit annoying to reproduce, and which only lasts for a split second. Often, after breaking blocks (especially in an enclosed space with torches), the cloud layer will render even when it should be completely obstructed by blocks. This is really jarring and frankly freaked me out the first time I saw it. Reproducible using only Better Clouds, Fabric API, and mod menu.

I'm able to reproduce the issue fairly reliably by making an enclosed underground space and just placing/breaking a bunch of torches and other blocks.

Screenshots of issue:

image

2022-01-04_14 43 05_2

@Qendolin
Copy link
Owner

Qendolin commented Jan 5, 2022

Can confirm, but it doesn't happen when breaking blocks but when picking up items, very strange.

@AeiouEnigma
Copy link
Contributor Author

The second screenshot was from Creative testing, when I was definitely not picking up any items, so there may be multiple causes.

@Qendolin
Copy link
Owner

Qendolin commented Jan 5, 2022

Are you sure? I can see you have 28 torches.

@AeiouEnigma
Copy link
Contributor Author

...........You may have a point. I hadn't considered the torches that would've fallen from me breaking the stone blocks.

@AeiouEnigma
Copy link
Contributor Author

That's a weird issue.

@Qendolin
Copy link
Owner

Qendolin commented Jan 5, 2022

Mojangs code is so messy, no wonder they have so many bugs. Something somewhere when picking up items disables the depth test and doesn't enable it again.

@Qendolin
Copy link
Owner

Qendolin commented Jan 5, 2022

Fixed https://modrinth.com/mod/better-clouds/version/f4jg6EtK

@Qendolin Qendolin closed this as completed Jan 5, 2022
@AeiouEnigma
Copy link
Contributor Author

I've confirmed that actually this issue still occurs 😭

@Qendolin
Copy link
Owner

Qendolin commented Jan 5, 2022

How 😶? The issue when picking up items is definitely fixed, gotta be something else...

@Qendolin Qendolin reopened this Jan 5, 2022
@Qendolin
Copy link
Owner

Qendolin commented Jan 5, 2022

Sorry, I can't recreate the issue anymore. Are you playing with other mods or different video settings?

@AeiouEnigma
Copy link
Contributor Author

I've reproduced it with only Better Clouds 1.0.3, still by picking up items.

If you're certain you've fixed it, is it possible you uploaded the wrong file?

@Qendolin
Copy link
Owner

Qendolin commented Jan 5, 2022

I feel so stupid rn, I did upload the wrong file. Even tho for testing I downloaded 1.0.3 from modrinth to make sure everything is ok. But I used my minecraft instance with a bunch of other mods that somehow prevented the bug from occurring.

This time, download from modrinth and tested in isolation: https://modrinth.com/mod/better-clouds/version/LVrQHf7k

@Qendolin Qendolin closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants