Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements #26

Merged
merged 2 commits into from Jun 24, 2020
Merged

improvements #26

merged 2 commits into from Jun 24, 2020

Conversation

SenCoder
Copy link
Contributor

There is no change for function, just some improvements for code readability.

  1. add IsValid & IsOnDuty method for UserGroup.
  2. extract record struct for alerts handlers.

1. add IsValid & IsOnDuty method for UserGroup.
2. extract record struct for alerts handlers.
@jayryu
Copy link
Collaborator

jayryu commented Jun 24, 2020

Thanks for your attention and contribution, and I want to know have you ever tested your code?

@SenCoder
Copy link
Contributor Author

SenCoder commented Jun 24, 2020

yes, yet I didn't fix much code as it looks like, just reduce some repeated code, and because the use of element.IsValid() && element.IsOnDuty() actually reduce the indents, it looks like so many modifications

@jayryu jayryu merged commit 2d7f81b into Qihoo360:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants