feat(serve): add --index-name to rewrite default index name #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timaschew
reviewed
Feb 18, 2019
| @@ -9,6 +9,7 @@ cache: | |||
| - ./node_modules | |||
| install: | |||
| - npm install | |||
| - npm install -g gulp | |||
| - npm install natives@1.1.6 | |||
| @@ -10,8 +10,8 @@ | |||
| "integrity": "sha512-3Sp6WZZ/lXl+nTDoGpGWHEpTnnC6X5fnkolYZR6nwIfzbxxvA8utPWe1gCt7i0m9uVGsSz2IS8K8mJ7HmlduMg==", | |||
| "dev": true, | |||
| "requires": { | |||
| "jsonparse": "^1.2.0", | |||
| "through": ">=2.2.7 <3" | |||
| "jsonparse": "1.3.1", | |||
There was a problem hiding this comment.
please remove package-lock.json and package.json changes
|
What a pitty. I didn't realize that after I've commented on lines I need to start a reiew explicitly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
I has 2 docs versions in same folder
index.public.htmlandindex.dev.htmlversions.To get them by
docsify-cliI need to create emptyindex.htmlAfter this PR
I've create a flag
--index-nameor-ito specify the default index file.Now I'm able to manually serve
index.public.htmlandindex.dev.html