Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chore): warn on unknown commands and command recommendation #74

Merged
merged 2 commits into from
Nov 18, 2019
Merged

fix(chore): warn on unknown commands and command recommendation #74

merged 2 commits into from
Nov 18, 2019

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented Nov 18, 2019 •
edited
Loading

closes #73

  • Warn on firing in unknown commands
  • Suggest matching commands if the user makes a typo.

anikethsaha
anikethsaha approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@anikethsaha anikethsaha mentioned this pull request Nov 18, 2019
Closed
@jamesgeorge007 jamesgeorge007 changed the title fix(chore): warn on unknown commands feat(chore): couple of validations Nov 18, 2019
@anikethsaha anikethsaha changed the title feat(chore): couple of validations fix(chore): warn on unknown commands and command recommendation Nov 18, 2019
@anikethsaha anikethsaha merged commit b46a707 into docsifyjs:master Nov 18, 2019
@jamesgeorge007 jamesgeorge007 deleted the hotfix/warn-on-unknown-cmd branch November 18, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikethsaha anikethsaha Awaiting requested review from anikethsaha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No warnings shown if unknown commands were passed in
2 participants
@jamesgeorge007 @anikethsaha