Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some items in sidebar highlight incorrectly. #86

Closed
reverland opened this issue Feb 20, 2017 · 5 comments
Closed

some items in sidebar highlight incorrectly. #86

reverland opened this issue Feb 20, 2017 · 5 comments
Labels
bug confirmed as a bug

Comments

@reverland
Copy link
Contributor

check https://docsify.js.org/#/cdn?id=other-cdn
click other-cdn, it won't be highlighted.

it is because sidebar highlight is computed from scroll position, but several headers in the last will never appear on top of viewport
@reverland
Copy link
Contributor Author

why not getAndActive(sidebar, true, true) when isMobile is false?

@QingWei-Li
Copy link
Member

The sidebar is hidden by default on the mobile. No need to scroll when the highlight.

@QingWei-Li QingWei-Li added the bug confirmed as a bug label Feb 20, 2017
@reverland
Copy link
Contributor Author

no, I mean even if its not in mobiles, getAndActive should be perform?

@QingWei-Li
Copy link
Member

Actually I just check the viewport less than 600px as a mobile.

@reverland
Copy link
Contributor Author

大佬orz，

我英文不好，就是想问不在viewport大于600px时getAndActive有什么考虑么

QingWei-Li added a commit that referenced this issue Feb 21, 2017
@QingWei-Li
fix(event): highlight sidebar when clicked, fixed #86
6b7fd41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed as a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reverland @QingWei-Li