Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline CI workflow #1073

Open
coruscating opened this issue Mar 9, 2023 · 2 comments
Open

Streamline CI workflow #1073

coruscating opened this issue Mar 9, 2023 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@coruscating
Copy link
Collaborator

coruscating commented Mar 9, 2023

We can combine the existing CI workflow files cron-staging.yml and main.yml with conditional keywords. See discussion here: #1062 (review)

As discussed in #1066, we can probably also remove push as a test condition. Another minor improvement would be to rename the dev docs build action in docs_dev.yml to something other than "Docs Publish", since that name is already taken by docs.yml (already done).

@coruscating coruscating added the good first issue Good for newcomers label Mar 9, 2023
@AbdullahKazi500
Copy link

AbdullahKazi500 commented Apr 15, 2023

Hi @coruscating it seems. you are discussing some changes to a GitHub Actions workflow file for a CI/CD pipeline. Specifically, you are suggesting that the cron-staging.yml and main.yml workflow files can be combined using conditional keywords.

You also mentioned that the push test condition can potentially be removed. This suggests that the workflow is triggered by a push to a repository, and removing this test condition would mean that the workflow would run on every push, rather than only on certain conditions .is this PR open for Bug Fixes I would like to take on this one Thank you

@coruscating
Copy link
Collaborator Author

@AbdullahKazi500 Yes, that's right, we'd like to merge the two files together into a single CI file with minimal repeated code. I'll assign this to you, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants