Update tomography kwargs #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihincks
reviewed
Dec 14, 2022
chriseclectic
force-pushed
the
tomo-kwargs
branch
from
9b1065b
to
911efa8
Compare
chriseclectic
added
Changelog: API Change
* Renames `qubits` kwarg of tomography experiments to `physical_qubits` to be more explicit. * Renames `measurement_qubits` and `preparation_qubits` kwargs of tomography experiments to `measurement_indices` and `preparation_indices` respectively. This is to avoid confusion since these args refer to the circuit qubit index in physical physical_qubits to be measurement or prepared. * Adds `backend` and `analysis` kwargs to StateTomography and ProcessTomography
Changes the default value of the analysis init kwarg for tomography experiments from None to "default". This is so that None can be used as a user supplied value to disable analysis for an experiment.
chriseclectic
force-pushed
the
tomo-kwargs
branch
from
996b7b5
to
6621253
Compare
ihincks
reviewed
Jan 19, 2023
ihincks
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
qubitskwarg of tomography experiments tophysical_qubitsto be more explicit.measurement_qubitsandpreparation_qubitskwargs of tomography experiments tomeasurement_indicesandpreparation_indicesrespectively. This is to avoid confusion since these args refer to the circuit qubit index in physical physical_qubits to be measurement or prepared.backendandanalysiskwargs to StateTomography and ProcessTomographyDetails and comments