-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tomography kwargs #998
Merged
chriseclectic
merged 6 commits into
qiskit-community:main
from
chriseclectic:tomo-kwargs
Jan 20, 2023
Merged
Update tomography kwargs #998
chriseclectic
merged 6 commits into
qiskit-community:main
from
chriseclectic:tomo-kwargs
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihincks
reviewed
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' good, minor comments.
9b1065b
to
911efa8
Compare
* Renames `qubits` kwarg of tomography experiments to `physical_qubits` to be more explicit. * Renames `measurement_qubits` and `preparation_qubits` kwargs of tomography experiments to `measurement_indices` and `preparation_indices` respectively. This is to avoid confusion since these args refer to the circuit qubit index in physical physical_qubits to be measurement or prepared. * Adds `backend` and `analysis` kwargs to StateTomography and ProcessTomography
Changes the default value of the analysis init kwarg for tomography experiments from None to "default". This is so that None can be used as a user supplied value to disable analysis for an experiment.
996b7b5
to
6621253
Compare
ihincks
reviewed
Jan 19, 2023
ihincks
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: API Change
Include in the "Changed" section of the changelog
Changelog: Deprecation
Include in "Deprecated" section of changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
qubits
kwarg of tomography experiments tophysical_qubits
to be more explicit.measurement_qubits
andpreparation_qubits
kwargs of tomography experiments tomeasurement_indices
andpreparation_indices
respectively. This is to avoid confusion since these args refer to the circuit qubit index in physical physical_qubits to be measurement or prepared.backend
andanalysis
kwargs to StateTomography and ProcessTomographyDetails and comments