Adjust CI trigger to run pre-merge on all pull requests #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adjust the ci configuration for mapomatic to run pre-merge on all opened PRs to the main branch. Previously it was configured to only run on push events which would get triggered by any commit being pushed to an upstream branch. However, this wouldn't run CI on a pull request opened from a fork until after it was merged. By changing this to trigger on pull requests we enable running the tests before we merge to make sure all proposed changes don't cause a regresssion.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjust the ci configuration for mapomatic to run pre-merge
on all opened PRs to the main branch. Previously it was configured to
only run on push events which would get triggered by any commit being
pushed to an upstream branch. However, this wouldn't run CI on a pull
request opened from a fork until after it was merged. By changing this
to trigger on pull requests we enable running the tests before we merge
to make sure all proposed changes don't cause a regresssion.