-
Notifications
You must be signed in to change notification settings - Fork 384
Add python 3.8 support and deprecate python 3.5 #722
Add python 3.8 support and deprecate python 3.5 #722
Conversation
This commit adds support for running aqua under python 3.8. It does this by adding the trove classifiers to the package metadata and adding a test job for python 3.8 At the same time this commit starts the deprecation window for python 3.5. Python 3.5 goes end of life by upstream python in Sept. 2020. We should give our users running with python 3.5 (which is about 10% of qiskit users this year based on pypi data) fair notice that when upstream python stops supporting it we do as well. Corresponding to this change, terra is going to start raising a warning when anything from qiskit.* is imported, see: Qiskit/qiskit#3268
It'd be good to determine if all of aqua's dependencies support python 3.8 before merging this, but since we don't run ci for anything but python 3.6 it's hard to tell that without manually testing locally. (the other elements are doing this in ci) |
Running a travis for python 3.8 and also trying on MacOS, the following dependencies don't install due to lack of a proper python 3.8 wheel file: pyscf, h5py and cvxopt. I found issues for h5py and cvxopt: The pycsf library build fails because it can't find libcint library. It seems to me that Aqua is not ready for python 3.8 until python 3.8 wheel files are provided for those libraries in Pypi or we would need instructions written on how the user can build and install those libraries for his OS before installing Aqua, assuming their code is ready for python 3.8 |
Well for cvxopt we should be moving away from that for license compatibility reasons (see Qiskit/qiskit-aer#430 and qiskit-community/qiskit-ignis#300). @dongreenberg said there is a plan for switching to sklearn which will take care of that here. But for the other ones that's definitely true I'll put this on hold and update the PR summary. It's probably worth pointing out that terra, aer, and ignis are blocked on supporting python 3.8 for one reason or another too. (terra on macOS also tripped a regression introduced in python3.8) so it might be a while before this can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing everything with 3.8 works now including logic using Ignis.
Cool, if you've manually tested it we can remove the on hold. I've got to update the ignis ci in qiskit-community/qiskit-ignis#298 in to pull in and build aer from source to get the 3.8 job working over there still. But if you've confirmed everything works here it's not like ignis needs a precompiled binary to install since it's all python code |
71c321e
…precate-3.5 Add python 3.8 support and deprecate python 3.5
I am using python 3.8.5 and when try to install: pip install qiskit-aqua[cvx] it shows en error (no match found) anyone had the same problems as me? |
Summary
This commit adds support for running aqua under python 3.8. It does
this by adding the trove classifiers to the package metadata and adding
a test job for python 3.8 At the same time this commit starts the
deprecation window for python 3.5. Python 3.5 goes end of life by
upstream python in Sept. 2020. We should give our users running with
python 3.5 (which is about 10% of qiskit users this year based on pypi
data) fair notice that when upstream python stops supporting it we do as
well. Corresponding to this change, terra is going to start raising a
warning when anything from qiskit.* is imported, see:
Qiskit/qiskit#3268
Details and comments
Python's documented branch support status and EoL dates are listed here:
https://devguide.python.org/#branchstatus
Waiting on upstream dependencies: