This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
[WIP] Ansatz Design Doc #747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to ansatz_design_doc
…nsatz_design_doc
…to ansatz_design_doc
…to ansatz_design_doc
…to ansatz_design_doc
…to ansatz_design_doc
…to ansatz_design_doc
dongreenberg
suggested changes
Jan 15, 2020
There was a problem hiding this comment.
@Cryoris Can you please wrap these into a directory so the supporting images aren't in the base design_docs directory?
|
@dongreenberg Done ✅ |
…to ansatz_design_doc
Cryoris
added a commit
to Cryoris/rfcs
that referenced
this pull request
Jan 22, 2020
|
@Cryoris closing this because it's been moved to Qiskit/RFCs#5 |
dongreenberg
pushed a commit
to Qiskit/RFCs
that referenced
this pull request
Jan 27, 2020
* migrate from qiskit-community/qiskit-aqua#747 * use directory according to rfc naming scheme * rename according to naming scheme * insert RFC overview table + review notes * Rename to 0001 * Rename ####-ansatz-rfc/0001-ansatz-rfc.ipynb to 0001-ansatz-rfc/0001-ansatz-rfc.ipynb * Rename files for merge into master. * Change status to accepted
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This design doc discusses the Ansatz class and the refactoring of the variational forms. The main goal of introducing the Ansatz is to reconcile all ansatz-style classes, such as variational forms, feature maps, and (potentially) initial states.
The notebook on this branch is a work in progress and open for discussion, suggestions and comments. If anyone is interested in contributing, please, reach out to discuss your thoughts or to get access to the branch!