Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add average_gate_fidelity, gate_error, and modify process_fidelity functions #3660

Merged
merged 7 commits into from Jan 21, 2020

Conversation

chriseclectic
Copy link
Member

Summary

  • Added average_gate_fidelity and gate_error function for operators
  • Update process_fidelity to requires target channel to be an Operator or None
    if target is None F computed wrt identity operator.
  • Deprecated require_cptp kwarg for process_fidelity
  • Added require_cp and require_tp kwargs for process_fidelity
    with defaults True and False

Details and comments

@ajavadia
Copy link
Member

can you add a couple tests and a release note

ajavadia
ajavadia previously approved these changes Dec 31, 2019
chriseclectic and others added 6 commits January 3, 2020 14:47
* Added ``average_gate_fidelity`` and ``gate_error`` function for operators
* ``process_fidelity`` requires target channel to be Operator or None
if target is None F computed wrt identity operator.
* Deprecated ``require_cptp`` kwarg for ``process_fidelity``
* Added ``require_cp`` and ``require_tp`` kwargs for ``process_fidelity``
with defaults True and False
@ajavadia ajavadia merged commit 13bc243 into Qiskit:master Jan 21, 2020
@kdk kdk added the Changelog: New Feature Include in the "Added" section of the changelog label Feb 4, 2020
@chriseclectic chriseclectic deleted the average_gate_fidelity branch February 18, 2020 18:49
faisaldebouni pushed a commit to faisaldebouni/qiskit-terra that referenced this pull request Aug 5, 2020
…idelity`` functions (Qiskit#3660)

* add average_gate_fidelity, gate_error, and modify process_fidelity

* Added ``average_gate_fidelity`` and ``gate_error`` function for operators
* ``process_fidelity`` requires target channel to be Operator or None
if target is None F computed wrt identity operator.
* Deprecated ``require_cptp`` kwarg for ``process_fidelity``
* Added ``require_cp`` and ``require_tp`` kwargs for ``process_fidelity``
with defaults True and False

* typo

* update documentation

* add tests

* add release note

* linting

Co-authored-by: Ali Javadi-Abhari <ajavadia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants