Flaky ComputeUncompute test in CI

[jakelishman]

Environment

• Qiskit Terra version: during merge of Fix PassManagerConfig.from_backend with BackendV1 and no CouplingMap #10172
• Python version: 3.8
• Operating system: macOS

What is happening?

CI reported a failure in an algorithms test that I've not seen before. It doesn't appear to be related to the PR in question (#10172), since it passed CI when up-to-date and not in the queue, and only failed when re-running the exact same commit in the queue.

This is my first time noticing this particular failure, so it could be that it's super rare. It'd be good to know for sure, though - the traceback below makes it look like there might be some mistaken handling of parameters somewhere.

How can we reproduce the issue?

Traceback from CI:

test.python.algorithms.state_fidelities.test_compute_uncompute.TestComputeUncompute.test_symmetry
-------------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/Users/runner/work/1/s/qiskit/algorithms/state_fidelities/compute_uncompute.py", line 161, in _run
    result = job.result()

      File "/Users/runner/work/1/s/qiskit/primitives/primitive_job.py", line 55, in result
    return self._future.result()

      File "/Users/runner/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/concurrent/futures/_base.py", line 437, in result
    return self.__get_result()

      File "/Users/runner/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/concurrent/futures/_base.py", line 389, in __get_result
    raise self._exception

      File "/Users/runner/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)

      File "/Users/runner/work/1/s/qiskit/primitives/sampler.py", line 88, in _call
    if len(value) != len(self._parameters[i]):

    IndexError: list index out of range

    
The above exception was the direct cause of the following exception:

    Traceback (most recent call last):

      File "/Users/runner/work/1/s/test/python/algorithms/state_fidelities/test_compute_uncompute.py", line 105, in test_symmetry
    results_2 = job_2.result()

      File "/Users/runner/work/1/s/qiskit/primitives/primitive_job.py", line 55, in result
    return self._future.result()

      File "/Users/runner/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/concurrent/futures/_base.py", line 437, in result
    return self.__get_result()

      File "/Users/runner/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/concurrent/futures/_base.py", line 389, in __get_result
    raise self._exception

      File "/Users/runner/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)

      File "/Users/runner/work/1/s/qiskit/algorithms/state_fidelities/compute_uncompute.py", line 163, in _run
    raise AlgorithmError("Sampler job failed!") from exc

    qiskit.algorithms.exceptions.AlgorithmError: 'Sampler job failed!'

What should happen?

Stable CI.

Any suggestions?

No response