Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port synth_permutation_basic to Rust #12225

Open
Tracked by #12212
mtreinish opened this issue Apr 19, 2024 · 2 comments
Open
Tracked by #12212

Port synth_permutation_basic to Rust #12225

mtreinish opened this issue Apr 19, 2024 · 2 comments
Assignees
Labels
performance Rust This PR or issue is related to Rust code in the repository synthesis

Comments

@mtreinish
Copy link
Member

No description provided.

@mtreinish mtreinish added performance synthesis Rust This PR or issue is related to Rust code in the repository labels Apr 19, 2024
@jpacold
Copy link

jpacold commented Apr 29, 2024

Hello -- I've been looking for open issues to work on and am potentially interested in this one.

It looks as if synth_permutation_basic just decomposes a permutation into transpositions by calling _get_ordered_swap, and then builds a circuit from the list of swaps.

Adding a Rust implementation of _get_ordered_swap to the accelerate crate is pretty straightforward. Looking at the top-level issue #12212, I'm not sure there is much more that can be done with this issue for now since the actual circuit has to be built in Python.

Is that an accurate assessment, and if so is it okay to work on this?

@hunterkemeny
Copy link
Contributor

@jpacold Sounds good, you can go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Rust This PR or issue is related to Rust code in the repository synthesis
Projects
None yet
Development

No branches or pull requests

3 participants