Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcry mode='basic' does not use ancillas #4786

Closed
ankprd opened this issue Jul 23, 2020 · 0 comments · Fixed by #4787
Closed

mcry mode='basic' does not use ancillas #4786

ankprd opened this issue Jul 23, 2020 · 0 comments · Fixed by #4787
Labels
bug Something isn't working status: pending PR It has one or more PRs pending to solve this issue
Projects

Comments

@ankprd
Copy link

ankprd commented Jul 23, 2020

Information

  • 0.14.2:
  • 3:
  • Ubuntu:

What is the current behavior?

The mcry gate (implemented in https://github.com/Qiskit/qiskit-terra/blob/master/qiskit/circuit/library/standard_gates/multi_control_rotation_gates.py) has a 'basic' mode that expects ancillas, but calls mct in its default 'noancilla' mode. (so both mcry(mode = 'noancilla') and mcry(mode='basic') use no ancillas and a lot of gates).

Steps to reproduce the problem

What is the expected behavior?

mcry in mode='basic' should call mct with mode='basic'

Suggested solutions

@ankprd ankprd added the bug Something isn't working label Jul 23, 2020
@Cryoris Cryoris added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jul 23, 2020
@1ucian0 1ucian0 added this to To do in Circuits via automation Jul 24, 2020
@1ucian0 1ucian0 added the status: pending PR It has one or more PRs pending to solve this issue label Jul 24, 2020
@kdk kdk added this to the 0.16 milestone Sep 15, 2020
@mergify mergify bot closed this as completed in #4787 Sep 29, 2020
Circuits automation moved this from To do to Done Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: pending PR It has one or more PRs pending to solve this issue
Projects
Circuits
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants