Add support for slice inputs to custom sequence return types #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for dealing with slice inputs to custom sequence return types such as NodeIndices. Previously, if a slice was requested from a custom return type it would have raised a TypeError. With this commit now it will return a new container object with a copy of the data from the requested slice. Fixes Qiskit#590
Pull Request Test Coverage Report for Build 2235984771
💛 - Coveralls |
georgios-ts
reviewed
Apr 27, 2022
Previously if an integer index was passed to `__getitem__` with a value equal to the negative length of the sequence we would incorrectly raise an except when instead the first element should have been returned. This commit fixes the handling of that edge case. Co-authored-by: georgios-ts <45130028+georgios-ts@users.noreply.github.com>
This commit fixes the handling of negative slices in sequence custom return types. Previouly using a negative step would cause a panic instead of correctly returning a reversed slice from the container. This commit corrects this so we can deal with negative slice steps too.
georgios-ts
approved these changes
Apr 27, 2022
Co-authored-by: georgios-ts <45130028+georgios-ts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for dealing with slice inputs to custom
sequence return types such as
NodeIndices. Previously, if a slicewas requested from a custom return type it would have raised a
TypeError. With this commit now it will return a new container objectwith a copy of the data from the requested slice.
Fixes #590