Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more connected components functions to retworkx-core #602

Open
enavarro51 opened this issue May 2, 2022 · 6 comments
Open

Move more connected components functions to retworkx-core #602

enavarro51 opened this issue May 2, 2022 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@enavarro51
Copy link
Contributor

What is the expected enhancement?

#595 is in the process of moving connected_components and number_connected_components from retworkx/src/connectivity/conn_components.rs to retworkx-core/src/connectivity/conn_components.rs.

There are a number of other connected component related functions in retworkx/src/connectivity/mod.rs, such as strongly_connected_components, is_connected, and node_connected_component, that could also be moved over to retworkx-core/src/connectivity. The function in mod.rs would then just call the retworkx-core version, similar to what's done with connected_components.

@mtreinish mtreinish added enhancement New feature or request good first issue Good for newcomers labels May 10, 2022
@kris524
Copy link

kris524 commented Jul 2, 2022

Hi @enavarro51, Is this issue still relevant? I would like to help as much as I can.

@enavarro51
Copy link
Contributor Author

Sure. Any of the functions in retworkx.src.connectivity.mod.rs that are not already in
retworkx.retworkx-core.src.connectivity could be moved in a way similar to the way connected_components was done. Let me know if you have any questions about it.

@acharyasourav
Copy link

Hey @enavarro51 I would like to work on this. I have read and also got the slightest idea of what needs to be done. Also, I'm unable to find the retworkx-core folder.

@kris524
Copy link

kris524 commented Sep 7, 2022

Hi @SUGARXUST thanks for reaching out. If you want you can have a look at my MR and help with testing and adding more stuff

@acharyasourav
Copy link

Sure I would like to help @kris524 please mention the request so that I can see what's going on and what can be done by me.

@kris524
Copy link

kris524 commented Sep 7, 2022

#638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants