Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color is causing issue to all my documentation #163

Closed
kopax opened this issue Oct 10, 2019 · 6 comments
Closed

Color is causing issue to all my documentation #163

kopax opened this issue Oct 10, 2019 · 6 comments

Comments

@kopax
Copy link

kopax commented Oct 10, 2019

I am using Webpack 4.41.0 and I have issue with production build of documentations.

I got all my documentation production build broken for some reason.

Example: https://rollup-umd.github.io/test/

Error: RangeError: Maximum call stack size exceeded

I haven't change anything in my source code. It just happen to be broken.

I can't remove UglifyJS plugin because react-styleguidist forbid it.

Current behavior

After running npm run styleguide:build, I have:

bundle.ebc589be.js:65 Uncaught RangeError: Maximum call stack size exceeded
    at e (bundle.ebc589be.js:65)
    at e (bundle.ebc589be.js:65)
   ...
Show 170 more frames

To reproduce

git clone git@github.com:rollup-umd/test.git
cd test
npm i
npm run styleguide:build
npm i -g serve
serve public
# open chrome and http://localhost:5000

Expected behavior

  • Work as in npm run styleguide.

Related information

It was working 24h ago, since then, I have not change anything in all my sources codes.

All my production build in all my projects are down.

I believe (unless I am wrong but to me it is the only valid reason): the dep tree as changed.

For those who ask why I don't have a lock file: It is because we do not use package-lock.json in distributed modules, because lock file are for application.

  • Does anybody have an idea of what changes recently?
  • Is there a way I can trace and find what cause all my documentations to be broken?

Related issue:

Debugging

I just added a breakpoint in the minified code and went up the trace, and it happen in a library called color, exactly here.

This file as not been changed since June, and the library where I use it here as also not changed since February.

Something must have change somewhere in the prod build and webpack is in charge of that.

It work on codepen.io : https://codesandbox.io/embed/peaceful-bouman-53ycx

This is the debugger showing me color:

image

I am not an expert but is there a way to fix that in color code ?

@Qix-
Copy link
Owner

Qix- commented Oct 10, 2019

I don't see how this is related at all to color. Out of the 6.8 million downloads per week, this is a problem only you're facing - and you admit yourself that it was working 24 hours ago.

I can't really begin to reproduce anything you're describing. Please reduce the problem to a minimal, compilable example.

Until then, there's nothing I can really do here.

@Qix- Qix- closed this as completed Oct 10, 2019
@kopax
Copy link
Author

kopax commented Oct 10, 2019

Qix- it seems to be working without terser, I am finding a way to skip this error but yeah that's not the right approach. Thanks!

@DamiJegede
Copy link

Same thing started for me as well when I pulled the module to my new computer from npm.

RangeError: Maximum call stack size exceeded
    at String.match (<anonymous>)
    at Function.cs.get.rgb (/Users/damilola/Roombus/roombus-roomos/node_modules/color-string/index.js:61:21)
    at Object.cs.get (/Users/damilola/Roombus/roombus-roomos/node_modules/color-string/index.js:33:17)
    at new Color (/Users/damilola/Roombus/roombus-roomos/node_modules/color/index.js:51:28)
    at Color (/Users/damilola/Roombus/roombus-roomos/node_modules/color/index.js:28:10)

@kopax
Copy link
Author

kopax commented Nov 4, 2019

For me this was related to an issue with terser : terser/terser#490

@DamiJegede
Copy link

Yeah, I see that. Mine is obviously coming from color-string — which is a dependency of color

@DamiJegede
Copy link

Alright. Wasn't from Color at all. Apologies for the false alarm. It was from another module, color-tween

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants