Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Tetradic and Triadic color palette generator #212

Closed
schie opened this issue Aug 9, 2021 · 2 comments
Closed

Adding Tetradic and Triadic color palette generator #212

schie opened this issue Aug 9, 2021 · 2 comments

Comments

@schie
Copy link

schie commented Aug 9, 2021

Hello!

I find myself constantly creating Tetradic and Triadic color palette w/ this library in numerous projects I work on.

Would you find any benefit in adding these to this lib?

For example:

const inputColor = Color('#FFFF00');

const triadics = inputColor.triadicPalette(); // [Color('#FFFF00'), Color('#00FFFF'), Color('#FF00FF')]
const tetradics = inputColor.tetradicPalette(); // [Color('#FFFF00'), Color('#00FF80'), Color('#0000FF'), Color('#FF0080')]

Triadic

Screen Shot 2021-08-08 at 11 27 48 PM

Tetradic

Screen Shot 2021-08-08 at 11 28 39 PM

If so, I'd be happy to make a PR.

@Qix-
Copy link
Owner

Qix- commented Aug 24, 2021

I'm on the fence about it, purely because it's not a commonly used feature (I understand you use it often but I haven't seen many examples of it elsewhere) and the library is already kind of stagnant because of the existing complicated API.

If you'd like to take the time to make a PR, that'd be great - just know that I might decide against it if it adds too much bulk.

@Qix-
Copy link
Owner

Qix- commented Apr 5, 2022

Hi, I've thought more about it and I don't think this fits within the scope of the package. Thanks for filing an issue though :)

@Qix- Qix- closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants