Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib unnecessarily requires @babel/preset-env? #227

Closed
lucastobrazil opened this issue Sep 28, 2021 · 1 comment
Closed

Lib unnecessarily requires @babel/preset-env? #227

lucastobrazil opened this issue Sep 28, 2021 · 1 comment
Labels

Comments

@lucastobrazil
Copy link

It appears that this library requires @babel/preset-env due to its use of Numeric Separators.

I was wondering if it's possible to not use the underscore in L257

for (const [i, element] of rgb.entries()) {
    const chan = element / 255;
    lum[i] = (chan <= 0.039_28) ? chan / 12.92 : ((chan + 0.055) / 1.055) ** 2.4;
}

Changing this would mean projects don't need to transpile it.

If agreed, I am happy to open a PR :)

@Qix-
Copy link
Owner

Qix- commented Sep 28, 2021

Please see the comments in other threads. I'm not interested in this.

Repository owner locked as resolved and limited conversation to collaborators Sep 28, 2021
@Qix- Qix- added the wontfix label Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants