feat: Add ScreenPad device support #2
Conversation
- Add checks for screenpad device presence in DSTS. - Set screenpad backlight to last value via DEVS backlight method. TODO: - Read connector power state (assumed powered after boot). - Write/Read backlight to/from a persistent ioregistry key.
TODO: - Store connector power and backlight level in ioregistry - Implement backlight + power read method using the WMI DEVS methods (or defer to custom ACPI read methods) - Bind backlight read and write methods to an IANE/ATK notification - Trigger OSD from IANE/ATK notification - Move backlight range handling to IANE/ATK
TODO: - Bind to IANE/ATK notification
|
What may make the most sense is applying and enforcing the screenpad on with the default backlight value from boot ( This lessens the dependence on extracting backlight/power values from potentially variable WMI DSTS/DEVS methods, and instead only uses backlight + connector write methods (which are expected to be consistent). The use of ioregistry for storing persistent values does need to be further explored. |
|
As a compromise, I've added fallbacks to the last stored backlight value in case DSTS methods fail to read the current device state. |
Qonfused
changed the title
|
A concern I had was how to integrate backlight handling w/ SMC keys. Screenpad backlight and power values do not necessarily need to be stored in order for their methods to function, as they are already stored in the EC registers accessible via WMI methods. Most VirtualSMCAPI keys have some kind of class or method defining types/methods to memoize or otherwise control their internal state. Most commonly, there is an This leaves only the SMC key + OSD display coupled with the AsusSMCDaemon and the WMI method handling with AsusSMC. |
This pull request adds native support for ASUS ScreenPad devices (e.g. Goodix GDX1515 and BOE BOE087F/BOE085F panels).
Tasks
0x00to0xFF).