Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still getting the following errors... #30

Closed
lstables opened this issue May 7, 2019 · 5 comments
Closed

Still getting the following errors... #30

lstables opened this issue May 7, 2019 · 5 comments

Comments

@lstables
Copy link

lstables commented May 7, 2019

I still get errors like this:

Screenshot 2019-05-07 at 09 14 23

And this:

Screenshot 2019-05-07 at 09 14 38

@ReeceM
Copy link
Collaborator

ReeceM commented May 7, 2019

Hi @lstables, that is caused by the fact that the mocker library doesn't account for arrays, that is something I new would be a possibility but didn't get my head around yet.

I will be having a look at the way of adding the ability to have an array, as just type hinting will not allow it to be multidimensional.

As with regards your second error. If you make the data attribute on the Mailable public you shouldn't need to pass it using the with statement as it is available already as is.

I will comment back on this when a patch is done. 👍

@lstables
Copy link
Author

lstables commented May 7, 2019

Awesome, thanks for the quick response and I'll look forward to the patch release ;)

@ReeceM
Copy link
Collaborator

ReeceM commented May 8, 2019

@lstables please run a composer update to get the mocker class to update to v1.1.1.

@Qoraiche
Copy link
Owner

Qoraiche commented May 8, 2019

Thanks for the quick fix @ReeceM

@lstables
Copy link
Author

lstables commented May 9, 2019

Awesome thanks @ReeceM and @Qoraiche for this awesome package and fixes. All working just fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants