New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(environment-variable): import feature #247
Conversation
Preview environments were automatically created via Qovery. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c7d7b3e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
I have a bug super strange. But of course, using value breaks our forms... |
I fixed that by changing the |
9c4e456
to
09793c0
Compare
...ture/import-environment-variable-modal-feature/import-environment-variable-modal-feature.tsx
Outdated
Show resolved
Hide resolved
libs/shared/interfaces/src/lib/domain/secret-environment-variable.entity.ts
Outdated
Show resolved
Hide resolved
8f37c3a
to
b4df427
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bdebon !!
Well done very clean and the coverage is nice 💯
Here are my suggestions in addition to remarks in the code:
- We don't have the export with terraform, I think you can remove it
- We have an white space at the right and left of the small input, it's little bit weird
-
We must not use Slices outside the domains, we have React context for small UI behavior
-
Missing hover state on the drop zone
- We don't have the "Warning block" and the table title are not in the good place (you integration vs the design)
- The warning icon looks too big, should be 20px of width and the margin-right is not the same with the design
...ture/import-environment-variable-modal-feature/import-environment-variable-modal-feature.tsx
Outdated
Show resolved
Hide resolved
...plication/src/lib/feature/import-environment-variable-modal-feature/utils/form-check.spec.ts
Show resolved
Hide resolved
...plication/src/lib/ui/import-environment-variable-modal/import-environment-variable-modal.tsx
Outdated
Show resolved
Hide resolved
libs/pages/application/src/lib/slices/environment-variable-ui.slice.ts
Outdated
Show resolved
Hide resolved
...plication/src/lib/ui/import-environment-variable-modal/import-environment-variable-modal.tsx
Outdated
Show resolved
Hide resolved
...plication/src/lib/ui/import-environment-variable-modal/import-environment-variable-modal.tsx
Outdated
Show resolved
Hide resolved
I created the component for the warning block, we can use it, but I removed it because the logic has changed a lot. |
Gg for the very precise review and suggestions! Gg bg |
What does this PR do?
todo:
setValue
the select will not show thatScreenshot of the actual work where I forced a wider a width